commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OGNL-35) [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
Date Fri, 04 Nov 2011 09:37:00 GMT

    [ https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143866#comment-13143866
] 

Hudson commented on OGNL-35:
----------------------------

Integrated in ognl #184 (See [https://builds.apache.org/job/ognl/184/])
    OGNL-35 - Flipped equals() everywhere where a variable is tested against a String constant.
OGNL-35 - CPD fix, extracted shared method getSourceBeanMethod() from getSourceSetter() and
getSourceAccessor().
OGNL-35 - CPD fix, extracted shared method getSourceString() from toGetSourceString() and
toSetSourceString().

mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197452
Files : 
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/MapPropertyAccessor.java

mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197448
Files : 
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ListPropertyAccessor.java

mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197443
Files : 
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProperty.java

                
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
> ------------------------------------------------------------------------
>
>                 Key: OGNL-35
>                 URL: https://issues.apache.org/jira/browse/OGNL-35
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Adrian Cumiskey
>            Priority: Minor
>         Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String constant.
> * ListPropertyAccessor: CPD fix, extracted shared method getSourceBeanMethod() from getSourceSetter()
and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from toGetSourceString()
and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from getSourceAccessor()
and getSourceSetter().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message