commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vincent Ricard (Updated) (JIRA)" <>
Subject [jira] [Updated] (LANG-598) DateUtils.isSameDay needs to factor in TimeZone
Date Mon, 14 Nov 2011 15:22:51 GMT


Vincent Ricard updated LANG-598:

    Attachment: LANG-598.patch

Here is a patch with some tests.
Can someone check my javadoc and correct it if needed please?
> DateUtils.isSameDay needs to factor in TimeZone
> -----------------------------------------------
>                 Key: LANG-598
>                 URL:
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.time.*
>    Affects Versions: 2.5
>            Reporter: Dan Checkoway
>             Fix For: 3.x
>         Attachments: LANG-598.patch
> DateUtils.isSameDay works great as long as you only care about the default system TimeZone.
 If you're trying to see if two Dates are the same day in *another* TimeZone, then you're
> For example, let's say the two dates being compared are:
> January 1, 2010 at 8:30pm PST
> January 1, 2010 at 9:30pm PST
> If your system TimeZone is PST, then sure, those two dates are on the "same day."  But
they are NOT the same day in EST, for example.
> The fix would be simple.  Add an isSameDay(Date, Date, TimeZone) method, and simply call
setTimezone on each of the Calendar objects constructed.
> The isSameDay(Calendar, Calendar) method can probably be left alone, since the caller
conceivably has called setTimeZone on the Calendar objects prior to calling isSameDay.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message