commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
Date Thu, 03 Nov 2011 09:03:32 GMT

    [ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142969#comment-13142969
] 

Hudson commented on OGNL-37:
----------------------------

Integrated in ognl #179 (See [https://builds.apache.org/job/ognl/179/])
    OGNL-37 - Modified equals() implementation to take account of super class fields.
OGNL-37 - Use Map.entrySet instead of Map.keySet for better performance.

mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197002
Files : 
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/internal/entry/DeclaredMethodCacheEntry.java

mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1196996
Files : 
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlContext.java

                
> [PATCH] Findbugs fixes
> ----------------------
>
>                 Key: OGNL-37
>                 URL: https://issues.apache.org/jira/browse/OGNL-37
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Adrian Cumiskey
>            Priority: Minor
>         Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override
PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always
of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class
fields.
> OgnlRuntime: Made static ints final.  Use Map.entrySet instead of Map.keySet for better
performance.  Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing.  Adjust unnecessary conditional checking.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message