Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Sat, 15 Oct 2011 18:33:14 +0000 (UTC)
From: "Daniel Pitts (Created) (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <829172049.17510.1318703594215.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Created] (OGNL-27) Move "toString" implementations into
 visitor pattern.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Move "toString" implementations into visitor pattern.
-----------------------------------------------------

                 Key: OGNL-27
                 URL: https://issues.apache.org/jira/browse/OGNL-27
             Project: OGNL
          Issue Type: New Feature
            Reporter: Daniel Pitts


Using the Visitor pattern allows for a cleaner implementation of toString().

I have a patch which will remove toString() from all AST classes, and replace it with a single toString() in "SimpleNode" which delegates to a ToStringVisitor to build the String efficiently.  

This patch can also be used as an example of how to move other business logic out of the AST classes into their own visitor classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira