Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Sat, 8 Oct 2011 19:03:30 +0000 (UTC)
From: "Christian Grobmeier (Commented) (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <587610228.11927.1318100610031.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1022056339.6114.1305184667438.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (OGNL-8) use javacc to generate AST* and
 OGNLParser Java sources
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/OGNL-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123552#comment-13123552 ] 

Christian Grobmeier commented on OGNL-8:
----------------------------------------

I added the change.

To enable jjtree too, one need to update the pom to run jjtree-javacc instead of javacc.

I suggest we change the package of the tree stuff to something else. Then customized versions can extend the originals and we clean them out one by one (*sigh*).

Anyway, I have not checked in that change, because it would lead to a compile error. For some reasons the parser will then call methods which are not generated in the AST files. very weird. Probably this is the reason for the customizing. 

Example: ASTConst does not contain setValue( Object ) in the generated sources.

If any ideas let me know, if not... will try to dig that one out.
                
> use javacc to generate AST* and OGNLParser Java sources
> -------------------------------------------------------
>
>                 Key: OGNL-8
>                 URL: https://issues.apache.org/jira/browse/OGNL-8
>             Project: OGNL
>          Issue Type: Task
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>         Attachments: OGNL-8-keep-custom-AST.patch, OGNL-8.patch, patch-ognl-8-v1.patch, patch-ognl-8-v2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira