Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D577291E0 for ; Wed, 5 Oct 2011 14:28:04 +0000 (UTC) Received: (qmail 57351 invoked by uid 500); 5 Oct 2011 14:28:04 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 57201 invoked by uid 500); 5 Oct 2011 14:28:04 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 57193 invoked by uid 99); 5 Oct 2011 14:28:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Oct 2011 14:28:04 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Oct 2011 14:28:02 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id AD2872AAF66 for ; Wed, 5 Oct 2011 14:27:40 +0000 (UTC) Date: Wed, 5 Oct 2011 14:27:40 +0000 (UTC) From: "Simone Tripodi (Commented) (JIRA)" To: issues@commons.apache.org Message-ID: <1032662540.12005.1317824860711.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1022056339.6114.1305184667438.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (OGNL-8) use javacc to generate AST* and OGNLParser Java sources MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OGNL-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121005#comment-13121005 ] Simone Tripodi commented on OGNL-8: ----------------------------------- Hi Daniel, I am worried you got us wrong, let's clarify misunderstanding before it is too late: there's nothing about lack of merit to patches, Apache projects are 100% community driven and, according to what Christian (one of the OGNL mentor/committer) reported in his [comment|https://issues.apache.org/jira/browse/OGNL-8?focusedCommentId=13119941&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13119941] {quote} [...] generates the parsers sources into /target/generated-sources/java and adds the folder to the classpath [...] {quote} It doesn't mean *your* patch cannot be committed, simply needed little improvements before be committed. I personally haven't had the time to read both patches, but since Christian is taking care of it, I strongly believe he is working in the way we all have this issue fixed, thanks also to the community support that people like you are volunteering on submitting patches. You will be indeed added in the contributors list, since you are participating on fixing issues. You, and smart volunteering people like you, are more than welcome, and we are happy to see new lifeblood participating on commons components. Please hijack your energies on submitting patches and take in consideration you are in a friendly environment! :) > use javacc to generate AST* and OGNLParser Java sources > ------------------------------------------------------- > > Key: OGNL-8 > URL: https://issues.apache.org/jira/browse/OGNL-8 > Project: OGNL > Issue Type: Task > Reporter: Olivier Lamy > Assignee: Olivier Lamy > Attachments: OGNL-8-keep-custom-AST.patch, OGNL-8.patch, patch-ognl-8-v1.patch, patch-ognl-8-v2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira