From issues-return-22287-apmail-commons-issues-archive=commons.apache.org@commons.apache.org Sat Oct 29 13:02:02 2011 Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1681B9435 for ; Sat, 29 Oct 2011 13:02:02 +0000 (UTC) Received: (qmail 69274 invoked by uid 500); 29 Oct 2011 13:02:01 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 69163 invoked by uid 500); 29 Oct 2011 13:02:01 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 69042 invoked by uid 99); 29 Oct 2011 13:02:01 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Oct 2011 13:02:01 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Oct 2011 13:01:58 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id B44A7326E05 for ; Sat, 29 Oct 2011 13:01:37 +0000 (UTC) Date: Sat, 29 Oct 2011 13:01:37 +0000 (UTC) From: "Adrian Cumiskey (Commented) (JIRA)" To: issues@commons.apache.org Message-ID: <546720297.36457.1319893297739.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <345086972.33504.1319836052434.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (OGNL-33) [PATCH] Improvements to JJTOgnlParserState MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/OGNL-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139259#comment-13139259 ] Adrian Cumiskey commented on OGNL-33: ------------------------------------- Hi Maurizio, I also noticed that this class was previously created by javacc. I looked through the codebaee and could not find the source of the generation. My guess is that it is no longer generated otherwise the class would most likely have resided in the generated/src tree. Perhaps we could now remove the generation comments? Thanks again for your timely processing of my patches. Cheers, Adrian. > [PATCH] Improvements to JJTOgnlParserState > ------------------------------------------ > > Key: OGNL-33 > URL: https://issues.apache.org/jira/browse/OGNL-33 > Project: OGNL > Issue Type: Improvement > Reporter: Adrian Cumiskey > Assignee: Maurizio Cucchiara > Priority: Minor > Attachments: patch-OGNL33.txt > > > JJTOgnlParserState was looking a little old school. > * Introduced generics on the "nodes" and "marks" List. > * Replaced 1-3 character acronyms with meaningful, camel case variable names. > * Removed unnecessary use of (un)boxing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira