[ https://issues.apache.org/jira/browse/OGNL-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121791#comment-13121791 ] 

Christian Grobmeier commented on OGNL-8:
----------------------------------------

@Maurizio: my patch is against trunk, not other patches need to be applied before. Looking at the patch, this beast does not reflect the move of the ognl.jj/ognl.jjt file (or so it seems). I suggest we go the way Simone proposed doing a nice CTR strategy.


@Daniel: For sure I didn't want to step on your tooth! Your work is great and actually is pretty similar to what I made. I cannot say mine is better. I just had problems applying the patch. Same story as Maurizio having problems with applying my patch. To be honest, it really looks as you have much more experience with JavaCC and I would LOVE to see you contributing more. Actually I learned from you that it is the parser I need to regenerate. Anyway, please follow commons dev list and discuss here. As Simone already mentioned, you are welcome.



                
> use javacc to generate AST* and OGNLParser Java sources
> -------------------------------------------------------
>
>                 Key: OGNL-8
>                 URL: https://issues.apache.org/jira/browse/OGNL-8
>             Project: OGNL
>          Issue Type: Task
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>         Attachments: OGNL-8-keep-custom-AST.patch, OGNL-8.patch, patch-ognl-8-v1.patch, patch-ognl-8-v2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira