commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Damjan Jovanovic (Commented) (JIRA)" <>
Subject [jira] [Commented] (SANSELAN-54) Tiff (exif) tags of type double written in wrong byte order
Date Sat, 15 Oct 2011 05:30:13 GMT


Damjan Jovanovic commented on SANSELAN-54:

Nice spot. I've written a test and also patched convertByteArrayToDouble() - it's wrong after
all, because it does things like "(0xff & byte0) << 56", but Java only uses the
lowest 5 bits (max 32 places) when left-shifting an int, so it actually needs "(0xffL &
byte0) << 56" to force conversion to long before the left-shift. I'm about to commit
everything now, thank you for your contribution.

> Tiff (exif) tags of type double written in wrong byte order
> -----------------------------------------------------------
>                 Key: SANSELAN-54
>                 URL:
>             Project: Commons Sanselan
>          Issue Type: Bug
>         Environment: Tested under Windows XP.  Potentally all platforms.
>            Reporter: Gary Lucas
>         Attachments: Sanselan-54-ExifByteOrder.patch
> Reviewing method convertDoubleToByteArray and convertDoubleArrayToByteArray
there are two blocks of code, one for BYTE_ORDER_MOTOROLA (big endian) and one for BYTE_ORDER_INTEL
(little endian).  These are backwards.  
> The convertByteArrayToDouble, on the other hand appears to be correct.  A reasonable
test procedure would be to see if these two sets of methods are mutually consistent.
> The same problem appears to be the case for the "Float" variants, but not the Integer

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message