commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (Commented) (JIRA)" <>
Subject [jira] [Commented] (OGNL-27) Move "toString" implementations into visitor pattern.
Date Sat, 15 Oct 2011 19:11:11 GMT


Simone Tripodi commented on OGNL-27:

sounds a very nice improvement, I'm going to have a look at the patch, thanks once again for
your contribution!
> Move "toString" implementations into visitor pattern.
> -----------------------------------------------------
>                 Key: OGNL-27
>                 URL:
>             Project: OGNL
>          Issue Type: New Feature
>            Reporter: Daniel Pitts
>         Attachments: to_string_visitor1.patch
> Using the Visitor pattern allows for a cleaner implementation of toString().
> I have a patch which will remove toString() from all AST classes, and replace it with
a single toString() in "SimpleNode" which delegates to a ToStringVisitor to build the String
> This patch can also be used as an example of how to move other business logic out of
the AST classes into their own visitor classes.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message