commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian Cumiskey (Commented) (JIRA)" <>
Subject [jira] [Commented] (OGNL-33) [PATCH] Improvements to JJTOgnlParserState
Date Sat, 29 Oct 2011 13:01:37 GMT


Adrian Cumiskey commented on OGNL-33:

Hi Maurizio,

I also noticed that this class was previously created by javacc.  I looked through the codebaee
and could not find the source of the generation.  My guess is that it is no longer generated
otherwise the class would most likely have resided in the generated/src tree. Perhaps we could
now remove the generation comments?  Thanks again for your timely processing of my patches.

Cheers, Adrian.
> [PATCH] Improvements to JJTOgnlParserState
> ------------------------------------------
>                 Key: OGNL-33
>                 URL:
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Adrian Cumiskey
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>         Attachments: patch-OGNL33.txt
> JJTOgnlParserState was looking a little old school.
> * Introduced generics on the "nodes" and "marks" List.
> * Replaced 1-3 character acronyms with meaningful, camel case variable names.
> * Removed unnecessary use of (un)boxing. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message