commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Grobmeier (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OGNL-8) use javacc to generate AST* and OGNLParser Java sources
Date Sun, 09 Oct 2011 05:06:30 GMT

    [ https://issues.apache.org/jira/browse/OGNL-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123619#comment-13123619
] 

Christian Grobmeier commented on OGNL-8:
----------------------------------------

I have looked a bit more deeply into the AST generation.
As Daniel already found out here: http://bit.ly/nB0xT6
it seems that the AST*files are meant for customization.

This is from the docs:
http://javacc.java.net/doc/JJTree.html

"If you don't provide implementations for the node classes JJTree will generate sample implementations
based on SimpleNode for you. You can then modify the implementations to suit."

When the Patches are reviewed on trunk, I would suggest to close this issue and look a bit
more into the Visitor possibilities of javacc, which might make it possible to move the custom
code to the visitor.
                
> use javacc to generate AST* and OGNLParser Java sources
> -------------------------------------------------------
>
>                 Key: OGNL-8
>                 URL: https://issues.apache.org/jira/browse/OGNL-8
>             Project: OGNL
>          Issue Type: Task
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>         Attachments: OGNL-8-keep-custom-AST.patch, OGNL-8.patch, patch-ognl-8-v1.patch,
patch-ognl-8-v2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message