commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OGNL-27) Move "toString" implementations into visitor pattern.
Date Sun, 16 Oct 2011 18:06:11 GMT

    [ https://issues.apache.org/jira/browse/OGNL-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128471#comment-13128471
] 

Hudson commented on OGNL-27:
----------------------------

Integrated in ognl #141 (See [https://builds.apache.org/job/ognl/141/])
    added OGNL-27 in the issue list
[OGNL-27] Move toString implementations into visitor pattern. - patch contributed by Daniel
Pitts

simonetripodi : http://svn.apache.org/viewvc/?view=rev&rev=1184886
Files : 
* /commons/proper/ognl/trunk/src/changes/changes.xml

simonetripodi : http://svn.apache.org/viewvc/?view=rev&rev=1184879
Files : 
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTAssign.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTBitNegate.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTConst.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTCtor.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTEval.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTIn.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTInstanceof.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTKeyValue.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTList.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMap.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNegate.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTNotIn.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProject.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTProperty.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTRootVarRef.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelect.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelectFirst.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSelectLast.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTSequence.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticField.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticMethod.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTThisVarRef.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTVarRef.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ExpressionNode.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/SimpleNode.java

                
> Move "toString" implementations into visitor pattern.
> -----------------------------------------------------
>
>                 Key: OGNL-27
>                 URL: https://issues.apache.org/jira/browse/OGNL-27
>             Project: OGNL
>          Issue Type: New Feature
>            Reporter: Daniel Pitts
>            Assignee: Simone Tripodi
>         Attachments: to_string_visitor1.patch, to_string_visitor2.patch, to_string_visitor_with_style_recommendations.patch
>
>
> Using the Visitor pattern allows for a cleaner implementation of toString().
> I have a patch which will remove toString() from all AST classes, and replace it with
a single toString() in "SimpleNode" which delegates to a ToStringVisitor to build the String
efficiently.  
> This patch can also be used as an example of how to move other business logic out of
the AST classes into their own visitor classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message