commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hendy Irawan (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (EXEC-39) StringUtils quoting problems
Date Fri, 28 Oct 2011 12:00:34 GMT

    [ https://issues.apache.org/jira/browse/EXEC-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138245#comment-13138245
] 

Hendy Irawan commented on EXEC-39:
----------------------------------

The string

{code}
web adoh '
{code}

is quoted into

{code}
"web adoh"
{code}

where it should be

{code}
"web adoh '"
{code}

                
> StringUtils quoting problems
> ----------------------------
>
>                 Key: EXEC-39
>                 URL: https://issues.apache.org/jira/browse/EXEC-39
>             Project: Commons Exec
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Sebb
>
> There are various problems in the StringUtils class:
> isQuoted() - does not check that arguments have the same opening and closing quotes.
This may be a rare case, but it's trivial to fix. There are no test cases for the method.
> quoteArgument()
>  - does not work properly on Windows, which only treats double-quote as a quoting character;
it should not fail if a Windows argument contains single-quotes, as they are not special.
> - does not quote special Unix characters either
> stringSubstitution() does not document what the characters can constitute a key.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message