commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maurizio Cucchiara (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OGNL-31) [PATCH] Some CPD fixes around ASTMethod and ASTStaticMethod.
Date Thu, 27 Oct 2011 10:34:33 GMT

    [ https://issues.apache.org/jira/browse/OGNL-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136950#comment-13136950
] 

Maurizio Cucchiara commented on OGNL-31:
----------------------------------------

@Adrian Cumiskey
Generally speaking I have no problem to apply your patch.
What doesn't convince me is that your patch changes lightly the semantics:
Did you take into consideration that changing the context changes the compiler (though I don't
know what side-effect could cause):
{code}
OgnlExpressionCompiler comp1 = OgnlRuntime.getCompiler( context );
context.put( "root2", new Root() );

OgnlExpressionCompiler comp2 = OgnlRuntime.getCompiler( context );
assertNotSame(comp2,comp1);
{code} 
                
> [PATCH] Some CPD fixes around ASTMethod and ASTStaticMethod.
> ------------------------------------------------------------
>
>                 Key: OGNL-31
>                 URL: https://issues.apache.org/jira/browse/OGNL-31
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Adrian Cumiskey
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>         Attachments: patch-OGNL31.txt
>
>
> I discovered a number of PMD CPD issues around ASTMethod and ASTStaticMethod class, there
was quite a bit of duplication there.
> This patch comes courtesy of the wifi connection in my local laundry-mat here in Milwaukee.
 Its strange the things people will do to make their clothes wash more quickly :-).
> Cheers, Adrian.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message