commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Pitts (Updated) (JIRA)" <>
Subject [jira] [Updated] (OGNL-27) Move "toString" implementations into visitor pattern.
Date Sun, 16 Oct 2011 17:32:12 GMT


Daniel Pitts updated OGNL-27:

    Attachment: to_string_visitor2.patch

Looks like someone committed some conflicts before you applied the patch. I updated and merged.
Here is the fixed patch.
> Move "toString" implementations into visitor pattern.
> -----------------------------------------------------
>                 Key: OGNL-27
>                 URL:
>             Project: OGNL
>          Issue Type: New Feature
>            Reporter: Daniel Pitts
>         Attachments: to_string_visitor1.patch, to_string_visitor2.patch, to_string_visitor_with_style_recommendations.patch
> Using the Visitor pattern allows for a cleaner implementation of toString().
> I have a patch which will remove toString() from all AST classes, and replace it with
a single toString() in "SimpleNode" which delegates to a ToStringVisitor to build the String
> This patch can also be used as an example of how to move other business logic out of
the AST classes into their own visitor classes.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message