commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Lucas (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SANSELAN-54) Tiff (exif) tags of type double written in wrong byte order
Date Tue, 04 Oct 2011 13:59:34 GMT

     [ https://issues.apache.org/jira/browse/SANSELAN-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gary Lucas updated SANSELAN-54:
-------------------------------

    Attachment: Sanselan-54-ExifByteOrder.patch

The following patch fixes the problem for both double and float data types.  It is based on
the latest version of the file BinaryFileFunctions.java obtained through SVN.
                
> Tiff (exif) tags of type double written in wrong byte order
> -----------------------------------------------------------
>
>                 Key: SANSELAN-54
>                 URL: https://issues.apache.org/jira/browse/SANSELAN-54
>             Project: Commons Sanselan
>          Issue Type: Bug
>         Environment: Tested under Windows XP.  Potentally all platforms.
>            Reporter: Gary Lucas
>         Attachments: Sanselan-54-ExifByteOrder.patch
>
>
> Reviewing BinaryFileFunctions.java method convertDoubleToByteArray and convertDoubleArrayToByteArray
there are two blocks of code, one for BYTE_ORDER_MOTOROLA (big endian) and one for BYTE_ORDER_INTEL
(little endian).  These are backwards.  
> The convertByteArrayToDouble, on the other hand appears to be correct.  A reasonable
test procedure would be to see if these two sets of methods are mutually consistent.
> The same problem appears to be the case for the "Float" variants, but not the Integer
variants.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message