commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (Resolved) (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (OGNL-27) Move "toString" implementations into visitor pattern.
Date Sun, 16 Oct 2011 17:44:11 GMT

     [ https://issues.apache.org/jira/browse/OGNL-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Simone Tripodi resolved OGNL-27.
--------------------------------

    Resolution: Fixed
      Assignee: Simone Tripodi

Patch successfully applied, see [r1184879|https://svn.apache.org/viewvc?view=revision&revision=1184879],
thanks a lot for this contribution!
                
> Move "toString" implementations into visitor pattern.
> -----------------------------------------------------
>
>                 Key: OGNL-27
>                 URL: https://issues.apache.org/jira/browse/OGNL-27
>             Project: OGNL
>          Issue Type: New Feature
>            Reporter: Daniel Pitts
>            Assignee: Simone Tripodi
>         Attachments: to_string_visitor1.patch, to_string_visitor2.patch, to_string_visitor_with_style_recommendations.patch
>
>
> Using the Visitor pattern allows for a cleaner implementation of toString().
> I have a patch which will remove toString() from all AST classes, and replace it with
a single toString() in "SimpleNode" which delegates to a ToStringVisitor to build the String
efficiently.  
> This patch can also be used as an example of how to move other business logic out of
the AST classes into their own visitor classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message