commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Grobmeier (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OGNL-21) Remove dead and broken code from OgnlRuntime/SimpleNode
Date Fri, 14 Oct 2011 07:50:11 GMT

    [ https://issues.apache.org/jira/browse/OGNL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127337#comment-13127337
] 

Christian Grobmeier commented on OGNL-21:
-----------------------------------------

All,

I have removed the deprecated method as suggestd and fixed some imports, dead code, unused
vars. Please have a review on it, if you have some time.

I finally did NOT delete all the methods in the patch initially proposed because of the discussion
here. Let us check if these methods can be fixed. If they do not make sense I suggest to @deprecate
them first before removing. I said different on the ML, but this discussion made me change
my mind.
                
> Remove dead and broken code from OgnlRuntime/SimpleNode
> -------------------------------------------------------
>
>                 Key: OGNL-21
>                 URL: https://issues.apache.org/jira/browse/OGNL-21
>             Project: OGNL
>          Issue Type: Task
>            Reporter: Daniel Pitts
>              Labels: cleanup
>         Attachments: Remove-dead-code.patch
>
>
> I noticed there are some apparently unnecessary methods in both SimpleNode and OgnlRuntime.
> I've created a patch which removes them, and the unit tests still run fine.
> One of the methods was clearly buggy and would cause ClassCastExceptions if used (it
put an array into a cache which was used to also store Maps).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message