commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OGNL-31) [PATCH] Some CPD fixes around ASTMethod and ASTStaticMethod.
Date Fri, 28 Oct 2011 17:21:32 GMT

    [ https://issues.apache.org/jira/browse/OGNL-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138555#comment-13138555
] 

Hudson commented on OGNL-31:
----------------------------

Integrated in ognl #169 (See [https://builds.apache.org/job/ognl/169/])
    OGNL-31 - Added compiler performance test
Added OGNL-31 to the change list
OGNL-31 - Some CPD fixes around ASTMethod and ASTStaticMethod (contributed by Adrian Cumiskey)

mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1190443
Files : 
* /commons/proper/ognl/trunk/src/benchmarks/java/org/apache/commons/ognl/performance/BasePerformanceTest.java
* /commons/proper/ognl/trunk/src/benchmarks/java/org/apache/commons/ognl/performance/invocation/CompilerInvocation.java
* /commons/proper/ognl/trunk/src/benchmarks/java/org/apache/commons/ognl/performance/runtime/CommonsRuntimeWrapper.java
* /commons/proper/ognl/trunk/src/benchmarks/java/org/apache/commons/ognl/performance/runtime/OldOgnlRuntimeWrapper.java
* /commons/proper/ognl/trunk/src/benchmarks/java/org/apache/commons/ognl/performance/runtime/RuntimeWrapper.java

mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1190437
Files : 
* /commons/proper/ognl/trunk/src/changes/changes.xml

mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1190434
Files : 
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethodUtil.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticMethod.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java
* /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/TestOgnlRuntime.java

                
> [PATCH] Some CPD fixes around ASTMethod and ASTStaticMethod.
> ------------------------------------------------------------
>
>                 Key: OGNL-31
>                 URL: https://issues.apache.org/jira/browse/OGNL-31
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Adrian Cumiskey
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>         Attachments: patch-OGNL31-v2.txt, patch-OGNL31.txt
>
>
> I discovered a number of PMD CPD issues around ASTMethod and ASTStaticMethod class, there
was quite a bit of duplication there.
> This patch comes courtesy of the wifi connection in my local laundry-mat here in Milwaukee.
 Its strange the things people will do to make their clothes wash more quickly :-).
> Cheers, Adrian.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message