Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Tue, 13 Sep 2011 19:09:08 +0000 (UTC)
From: "Simone Tripodi (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <1861219208.23535.1315940948927.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <158548827.23024.1315935909317.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (OGNL-21) Remove dead and broken code from
 OgnlRuntime/SimpleNode
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/OGNL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103913#comment-13103913 ] 

Simone Tripodi commented on OGNL-21:
------------------------------------

Thanks for contributing Daniel, anyway before applying the patch I would like to make sure that code is unnecessary, your words "there are some *apparently* unnecessary methods" worry me a little.
What is the metric you used to check dead code?
Many thanks in advance!

> Remove dead and broken code from OgnlRuntime/SimpleNode
> -------------------------------------------------------
>
>                 Key: OGNL-21
>                 URL: https://issues.apache.org/jira/browse/OGNL-21
>             Project: OGNL
>          Issue Type: Task
>            Reporter: Daniel Pitts
>              Labels: cleanup
>         Attachments: Remove-dead-code.patch
>
>
> I noticed there are some apparently unnecessary methods in both SimpleNode and OgnlRuntime.
> I've created a patch which removes them, and the unit tests still run fine.
> One of the methods was clearly buggy and would cause ClassCastExceptions if used (it put an array into a cache which was used to also store Maps).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira