commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CHAIN-54) upgrate JUnit dependency to latest released version and adapt tests
Date Tue, 13 Sep 2011 21:11:09 GMT

    [ https://issues.apache.org/jira/browse/CHAIN-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103991#comment-13103991
] 

Simone Tripodi commented on CHAIN-54:
-------------------------------------

Tests just updated, see [r1170348|https://svn.apache.org/viewvc?view=revision&revision=1170348].

There was a big mistake in the {{org.apache.commons.chain.web.servlet.ServletSetLocaleCommandTestCase}}
(due to copy'n'paste side effects) that was testing the {{ServletGetLocaleCommand}} instead
of {{ServletSetLocaleCommand}}.

The issue cannot be closed, I just realized that some tests use test parameters and it would
be better use the proper JUnit [Parameterized|http://junit.sourceforge.net/javadoc/org/junit/runners/Parameterized.html]
canonical form instead of manually cycling on args array.

> upgrate JUnit dependency to latest released version and adapt tests
> -------------------------------------------------------------------
>
>                 Key: CHAIN-54
>                 URL: https://issues.apache.org/jira/browse/CHAIN-54
>             Project: Commons Chain
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>             Fix For: 2.0
>
>
> JUnit dependency should be migrated to latest stable 4.X released - and would be better
updating tests

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message