commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Pitts (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OGNL-21) Remove dead and broken code from OgnlRuntime/SimpleNode
Date Mon, 26 Sep 2011 20:46:12 GMT

    [ https://issues.apache.org/jira/browse/OGNL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114906#comment-13114906
] 

Daniel Pitts commented on OGNL-21:
----------------------------------

Indeed.  As far as the CompoundRootAccessor usage, I had found that and commented on it. There
is a very quick fix for the struts source (which could be made immediately AFAICT):

-OgnlRuntime.callMethod((OgnlContext) context, o, name, name, objects);
+OgnlRuntime.callMethod((OgnlContext) context, o, name, objects);

The callMethod(OgnleContext, Object, String, String, Object[]) method is deprecated anyway.
I'm fine leaving that one in if you feel the need to, however I was considering since this
is for a release with a new major version number, it could be a good time to remove deprecated
methods and the like.


                
> Remove dead and broken code from OgnlRuntime/SimpleNode
> -------------------------------------------------------
>
>                 Key: OGNL-21
>                 URL: https://issues.apache.org/jira/browse/OGNL-21
>             Project: OGNL
>          Issue Type: Task
>            Reporter: Daniel Pitts
>              Labels: cleanup
>         Attachments: Remove-dead-code.patch
>
>
> I noticed there are some apparently unnecessary methods in both SimpleNode and OgnlRuntime.
> I've created a patch which removes them, and the unit tests still run fine.
> One of the methods was clearly buggy and would cause ClassCastExceptions if used (it
put an array into a cache which was used to also store Maps).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message