commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OGNL-21) Remove dead and broken code from OgnlRuntime/SimpleNode
Date Wed, 14 Sep 2011 05:58:09 GMT

    [ https://issues.apache.org/jira/browse/OGNL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104277#comment-13104277
] 

Simone Tripodi commented on OGNL-21:
------------------------------------

It would be nice if some maven plugin could generate the same report, so we could publish
it in the site and ask the community if they use such methods or not.
The worry is, indeed, removing methods that users rely on, so they maybe just need to be better
tested :P

> Remove dead and broken code from OgnlRuntime/SimpleNode
> -------------------------------------------------------
>
>                 Key: OGNL-21
>                 URL: https://issues.apache.org/jira/browse/OGNL-21
>             Project: OGNL
>          Issue Type: Task
>            Reporter: Daniel Pitts
>              Labels: cleanup
>         Attachments: Remove-dead-code.patch
>
>
> I noticed there are some apparently unnecessary methods in both SimpleNode and OgnlRuntime.
> I've created a patch which removes them, and the unit tests still run fine.
> One of the methods was clearly buggy and would cause ClassCastExceptions if used (it
put an array into a cache which was used to also store Maps).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message