commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Pitts (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OGNL-21) Remove dead and broken code from OgnlRuntime/SimpleNode
Date Mon, 19 Sep 2011 00:02:08 GMT

    [ https://issues.apache.org/jira/browse/OGNL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107563#comment-13107563
] 

Daniel Pitts commented on OGNL-21:
----------------------------------

That's fine by me Simone.  I'm assuming you mean Struts, not Structs. FWIW, google code search
does include apache commons and googlecode repositories, so my research above included Struts
and MyBatis. 

Is that communication to the ML something you are willing to take on?  I'm new to the open-source
contribution scene and I'm not quite sure I'd know the best way to present this.



> Remove dead and broken code from OgnlRuntime/SimpleNode
> -------------------------------------------------------
>
>                 Key: OGNL-21
>                 URL: https://issues.apache.org/jira/browse/OGNL-21
>             Project: OGNL
>          Issue Type: Task
>            Reporter: Daniel Pitts
>              Labels: cleanup
>         Attachments: Remove-dead-code.patch
>
>
> I noticed there are some apparently unnecessary methods in both SimpleNode and OgnlRuntime.
> I've created a patch which removes them, and the unit tests still run fine.
> One of the methods was clearly buggy and would cause ClassCastExceptions if used (it
put an array into a cache which was used to also store Maps).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message