Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Mon, 8 Aug 2011 20:23:27 +0000 (UTC)
From: =?utf-8?Q?Arne_Pl=C3=B6se_=28JIRA=29?= <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <88046562.17635.1312835007206.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1412690642.14813.1312731207444.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MATH-643) Rename RealVector.map* to
 RealVector.ebe* (mapAdd(...) to ebeAdd(...) and mapAddToSelf(...) to
 ebeAddToSelf(...) for instance
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MATH-643?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D130811=
67#comment-13081167 ]=20

Arne Pl=C3=B6se commented on MATH-643:
---------------------------------

@perl
http://perldoc.perl.org/functions/map.html
says that map evaluates a BLOCK or EXPR given to map. This is what RealVect=
or.map(...) does - nothing wrong with this.
But mapAdd(double d) is a simple addition of d to each element of the vecto=
r - I would say name this mapping is wrong in this case.
{code}AbstractRealvector.mappAddToSelf(double d){code} uses internally mapp=
ing so this may be OK - but I cant see any benefit from this.

I think the reason for ebe and map is only dotProduct|outherProduct|ebeMult=
iply to make clear what the methods are doing.
By the way add(double[] v] should be renamend to ebeAdd(double[] v) to be c=
onsistent with the naming scheme.

> Rename RealVector.map* to RealVector.ebe* (mapAdd(...) to ebeAdd(...) and=
 mapAddToSelf(...) to ebeAddToSelf(...) for instance
> -------------------------------------------------------------------------=
----------------------------------------------------
>
>                 Key: MATH-643
>                 URL: https://issues.apache.org/jira/browse/MATH-643
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Arne Pl=C3=B6se
>            Priority: Minor
>
> I think the map* methods have historical names. Today I would prefer ebe =
as prefix like ebeMultiply(...).
> This would describe the methods better from a users view.
> If this is a valid issue, I could provide a patch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira