Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Wed, 24 Aug 2011 12:41:29 +0000 (UTC)
From: =?utf-8?Q?S=C3=A9bastien_Brisard_=28JIRA=29?= <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <610393609.9086.1314189689290.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <790743550.36906.1313308828518.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Issue Comment Edited] (MATH-646) Unmodifiable views of
 RealVector
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MATH-646?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D130901=
79#comment-13090179 ]=20

S=C3=A9bastien Brisard edited comment on MATH-646 at 8/24/11 12:40 PM:
------------------------------------------------------------------

{quote}
Before posting a patch, please don't forget to look at the output of "mvn c=
lean site" for Javadoc warnings and at "checkstyle.html" (in "target/site")=
.
{quote}
I'm sorry, I'll do that next time. I must have mis-configured checkstyle in=
 my Eclipse. Sorry again to waste your time.

{quote}
Couldn't we call the "unmodifiableRealVector" method simply "unmodifiableVe=
ctor"?
{quote}
I'm all for it. Are you going to do it, or should I submit a new patch?

While we are at it, shouldn't we provide an unmodifiable view of matrices, =
following the same lines? Shall I open a JIRA ticket?

      was (Author: celestin):
    {quote}
Before posting a patch, please don't forget to look at the output of "mvn c=
lean site" for Javadoc warnings and at "checkstyle.html" (in "target/site")=
.
{quote}
I'm sorry, I'll do that next time. I must have mis-configured checkstyle in=
 my Eclipse. Sorry again to waste your time.

{quote}
Couldn't we call the "unmodifiableRealVector" method simply "unmodifiableVe=
ctor"?
{quote}
I'm all for it.

While we are at it, shouldn't we provide an unmodifiable view of matrices, =
following the same lines? Shall I open a JIRA ticket?
 =20
> Unmodifiable views of RealVector
> --------------------------------
>
>                 Key: MATH-646
>                 URL: https://issues.apache.org/jira/browse/MATH-646
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 3.0
>            Reporter: S=C3=A9bastien Brisard
>              Labels: linear, vector
>         Attachments: MATH-646.patch, MATH-646.patch
>
>
> The issue has been discussed on the [mailing list|http://mail-archives.ap=
ache.org/mod_mbox/commons-dev/201108.mbox/<CAGRH7HqxUb2y1HmFt9VJ-kxsXwipk_M=
dO0D=3DrNuazmGPNOTVrA@mail.gmail.com>]. Please find attached a proposal for=
 a new class {{UnmodifiableRealVector}}. I chose not to nest it in {{Abstra=
ctRealVector}} because it would make the corresponding file huge. Therefore=
, {{UnmodifiableRealVector}} is {{final}}. Maybe you'd like it to be {{priv=
ate}} as well? A static method is provided in {{AbstractRealVector}} to bui=
ld an {{UnmodifiableRealVector}} from any {{RealVector}}.
> Tests are also provided. Since iterating through different implementation=
s of {{RealVector}} is actually different, a test is provided for {{Unmodif=
iableRealVector}} built on {{ArrayRealVector}} and {{OpenMapRealVector}}. T=
hese tests both derive from the same abstract test class. Hope everything w=
orks fine.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira