commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sébastien Brisard (JIRA) <>
Subject [jira] [Commented] (MATH-646) Unmodifiable views of RealVector
Date Wed, 24 Aug 2011 12:37:30 GMT


Sébastien Brisard commented on MATH-646:

Before posting a patch, please don't forget to look at the output of "mvn clean site" for
Javadoc warnings and at "checkstyle.html" (in "target/site").
I'm sorry, I'll do that next time. I must have mis-configured checkstyle in my Eclipse. Sorry
again to waste your time.

Couldn't we call the "unmodifiableRealVector" method simply "unmodifiableVector"?
I'm all for it.

While we are at it, shouldn't we provide an unmodifiable view of matrices, following the same
lines? Shall I open a JIRA ticket?

> Unmodifiable views of RealVector
> --------------------------------
>                 Key: MATH-646
>                 URL:
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 3.0
>            Reporter: Sébastien Brisard
>              Labels: linear, vector
>         Attachments: MATH-646.patch, MATH-646.patch
> The issue has been discussed on the [mailing list|<>].
Please find attached a proposal for a new class {{UnmodifiableRealVector}}. I chose not to
nest it in {{AbstractRealVector}} because it would make the corresponding file huge. Therefore,
{{UnmodifiableRealVector}} is {{final}}. Maybe you'd like it to be {{private}} as well? A
static method is provided in {{AbstractRealVector}} to build an {{UnmodifiableRealVector}}
from any {{RealVector}}.
> Tests are also provided. Since iterating through different implementations of {{RealVector}}
is actually different, a test is provided for {{UnmodifiableRealVector}} built on {{ArrayRealVector}}
and {{OpenMapRealVector}}. These tests both derive from the same abstract test class. Hope
everything works fine.

This message is automatically generated by JIRA.
For more information on JIRA, see:


View raw message