commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sébastien Brisard (JIRA) <j...@apache.org>
Subject [jira] [Commented] (MATH-646) Unmodifiable views of RealVector
Date Wed, 24 Aug 2011 12:37:30 GMT

    [ https://issues.apache.org/jira/browse/MATH-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090179#comment-13090179
] 

Sébastien Brisard commented on MATH-646:
----------------------------------------

{quote}
Before posting a patch, please don't forget to look at the output of "mvn clean site" for
Javadoc warnings and at "checkstyle.html" (in "target/site").
{quote}
I'm sorry, I'll do that next time. I must have mis-configured checkstyle in my Eclipse. Sorry
again to waste your time.

{quote}
Couldn't we call the "unmodifiableRealVector" method simply "unmodifiableVector"?
{quote}
I'm all for it.

While we are at it, shouldn't we provide an unmodifiable view of matrices, following the same
lines? Shall I open a JIRA ticket?

> Unmodifiable views of RealVector
> --------------------------------
>
>                 Key: MATH-646
>                 URL: https://issues.apache.org/jira/browse/MATH-646
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 3.0
>            Reporter: Sébastien Brisard
>              Labels: linear, vector
>         Attachments: MATH-646.patch, MATH-646.patch
>
>
> The issue has been discussed on the [mailing list|http://mail-archives.apache.org/mod_mbox/commons-dev/201108.mbox/<CAGRH7HqxUb2y1HmFt9VJ-kxsXwipk_MdO0D=rNuazmGPNOTVrA@mail.gmail.com>].
Please find attached a proposal for a new class {{UnmodifiableRealVector}}. I chose not to
nest it in {{AbstractRealVector}} because it would make the corresponding file huge. Therefore,
{{UnmodifiableRealVector}} is {{final}}. Maybe you'd like it to be {{private}} as well? A
static method is provided in {{AbstractRealVector}} to build an {{UnmodifiableRealVector}}
from any {{RealVector}}.
> Tests are also provided. Since iterating through different implementations of {{RealVector}}
is actually different, a test is provided for {{UnmodifiableRealVector}} built on {{ArrayRealVector}}
and {{OpenMapRealVector}}. These tests both derive from the same abstract test class. Hope
everything works fine.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message