commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <>
Subject [jira] [Commented] (MATH-646) Unmodifiable views of RealVector
Date Mon, 15 Aug 2011 21:05:27 GMT


Gilles commented on MATH-646:

There must be one public (or with package access) class in each Java source file.
But you can have additional ones (without access qualifier), not necessarily nested. Thus,
in "":
public class AbstractRealVector implements RealVector {
  // ...

  public static RealVector unmodifiableRealVector(RealVector v) {
    return new UnmodifiableRealVector(v);

class UnmodifiableRealVector implements RealVector {
  // ...

This makes for slightly less cluttered code.

> Unmodifiable views of RealVector
> --------------------------------
>                 Key: MATH-646
>                 URL:
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 3.0
>            Reporter: S├ębastien Brisard
>              Labels: linear, vector
>         Attachments: MATH-646.patch
> The issue has been discussed on the [mailing list|<>].
Please find attached a proposal for a new class {{UnmodifiableRealVector}}. I chose not to
nest it in {{AbstractRealVector}} because it would make the corresponding file huge. Therefore,
{{UnmodifiableRealVector}} is {{final}}. Maybe you'd like it to be {{private}} as well? A
static method is provided in {{AbstractRealVector}} to build an {{UnmodifiableRealVector}}
from any {{RealVector}}.
> Tests are also provided. Since iterating through different implementations of {{RealVector}}
is actually different, a test is provided for {{UnmodifiableRealVector}} built on {{ArrayRealVector}}
and {{OpenMapRealVector}}. These tests both derive from the same abstract test class. Hope
everything works fine.

This message is automatically generated by JIRA.
For more information on JIRA, see:


View raw message