commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William R. Speirs (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (DBUTILS-78) Add asynchronous batch, query, and update calls
Date Wed, 10 Aug 2011 14:03:27 GMT

    [ https://issues.apache.org/jira/browse/DBUTILS-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082349#comment-13082349
] 

William R. Speirs edited comment on DBUTILS-78 at 8/10/11 2:03 PM:
-------------------------------------------------------------------

1) Yea, we'll need Java 6 for the future stuff. Wasn't sure what the project's posture on
that is.
2) Not a problem... documentation is key.

However, I don't think this patch should be accepted as-is :-) There is a LOT of duplicate
code in my patch. I did this because I didn't want to mess with the QueryRunner code if everyone
thought my idea was stupid. However, there are a number of methods in the AsyncQueryRunner
are improved from the QueryRunner (see DBUTILS-79).

I propose that we create a base or abstract class which both QueryRunner and AsyncQueryRunner
extend. Thoughts?


      was (Author: wspeirs):
    1) Yea, we'll need Java 6 for the future stuff. Wasn't sure what the project's posture
on that is.
2) Not a problem... documentation is key.

However, I don't think this patch should be accepted as-is :-) There is a LOT of duplicate
code in my patch. I did this because I didn't want to mess with the QuerryRunner code if everyone
thought my idea was stupid. However, there are a number of methods in the AsyncQuerryRunner
are improved from the QuerryRunner (see DBUTILS-79).

I propose that we create a base or abstract class which both QuerryRunner and AsyncQuerryRunner
extend. Thoughts?

  
> Add asynchronous batch, query, and update calls
> -----------------------------------------------
>
>                 Key: DBUTILS-78
>                 URL: https://issues.apache.org/jira/browse/DBUTILS-78
>             Project: Commons DbUtils
>          Issue Type: New Feature
>            Reporter: William R. Speirs
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: AsyncQueryRunner.java, AsyncQueryRunnerTest.java, pom.diff
>
>
> I propose a new QueryRunner class, AsyncQueryRunner, which changes the return type of
batch, query, and update methods. Instead of returning their respective return types, the
methods would return a RunnableFuture. This would allow callers to either execute the RunnableFuture
in a thread or via an CompletionService like the ExecutorCompletionService.
> I have attached a first cut at this class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message