commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-460) Levy Distribution
Date Fri, 19 Aug 2011 22:27:27 GMT

    [ https://issues.apache.org/jira/browse/MATH-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088026#comment-13088026
] 

Gilles commented on MATH-460:
-----------------------------

* In "LevyDistribution.java":
** Javadoc typo: "mean" instead of "median".
* In "LevyDistributionImpl.java":
** The license header is missing.
** Instance fields should be declared "final".
** "erfConst" should have a more explict name like "INVERSE_ERF_HALF_SQUARED" (?)
** Couldn't "erfConst" be computed? Couldn't there be more than 10 significant digits?
** Shouldn't "getDomainUpperBound" return "POSITIVE_INFINITY" instead of "MAX_VALUE"?
* In "LevyDistributionTest.java":
** JUnit4 "import" statements are missing.
** The constructor is unnecessary and should be removed.
** The additional test cases are not marked with "@Test".

The patch is old; it does not compile on the current trunk:
{noformat}
[...]/LevyDistributionImpl.java:[18,7] org.apache.commons.math.distribution.LevyDistributionImpl
is not abstract and does not override abstract method getSupportUpperBound() in org.apache.commons.math.distribution.AbstractContinuousDistribution
{noformat}


> Levy Distribution
> -----------------
>
>                 Key: MATH-460
>                 URL: https://issues.apache.org/jira/browse/MATH-460
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Pavel Ryzhov
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: levy_math_460.patch
>
>
> Pretty straightforward implementation of Levy Distribution (not Levy alpha-stable) according
to http://en.wikipedia.org/wiki/Lévy_distribution.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message