commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elijah Zupancic (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CHAIN-53) Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
Date Mon, 29 Aug 2011 20:55:37 GMT

    [ https://issues.apache.org/jira/browse/CHAIN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093194#comment-13093194
] 

Elijah Zupancic commented on CHAIN-53:
--------------------------------------

@Matt Benson

Thanks for catching that. For some reason, that implementation detail slipped my mind. I will
write a unit test to see if the existing API supports NULL keys. Since the context base uses
JavaBeanUtils to map keys to class setters / getters, it may very well not support null keys.


> Global Update of Chain - Generics, JDK 1.5, Update Dependency Versions
> ----------------------------------------------------------------------
>
>                 Key: CHAIN-53
>                 URL: https://issues.apache.org/jira/browse/CHAIN-53
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Elijah Zupancic
>            Assignee: Simone Tripodi
>              Labels: newbie, patch
>         Attachments: CHAIN-53_2011-08-25.patch
>
>
> As posted in the mailing list, I've done this work outside of an offical branch.
> In this patch:
> * Global upgrade to the JDK 1.5
> * Added @Override annotations
> * Upgraded to the Servlet 2.5 API
> * Upgraded to the Faces 2.1 API
> * Upgraded to the Portlet 2.0 API
> * Upgraded the Maven Parent POM version
> * Added generics support to Command so that Command's API looks like:
> public interface Command<T extends Context> {
> ...
>    boolean execute(T context) throws Exception;
> }
> The only incompatibility with the existing API is in: org.apache.commons.chain.web.servlet.ServletHeaderValuesMap
on line 97. Previously the API was returning Set<Entry<String, Enumeration<String>>
when by all indications it actually should have been returning Set<Entry<String, String[]>>.
I believe that I fixed a previously undiscovered bug here.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message