commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (MATH-506) The static field ChiSquareTestImpl.distribution serves no purpose
Date Sat, 20 Aug 2011 21:16:49 GMT

     [ https://issues.apache.org/jira/browse/MATH-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Phil Steitz resolved MATH-506.
------------------------------

    Resolution: Fixed

I removed the field (hence eliminating pluggability) in r1159916.  As of 3.0, the distribution
classes are immutable, so to support pluggability a factory or class name rather than a distribution
instance would have to be provided.  There is only one implementation provided by [math],
so I do not see this as worth the effort and complexity to retain.

> The static field ChiSquareTestImpl.distribution serves no purpose
> -----------------------------------------------------------------
>
>                 Key: MATH-506
>                 URL: https://issues.apache.org/jira/browse/MATH-506
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 1.2, 2.0, 2.1, 2.2
>            Reporter: Sebb
>            Assignee: Phil Steitz
>            Priority: Minor
>             Fix For: 3.0
>
>
> The static field ChiSquareTestImpl.distribution serves no purpose.
> There is a setter for it, but in every case where the field is used, it is first overwritten
with a new value.
> The field and the setter should be removed, and the methods that create a new instance
should create a local variable instead.
> For Math 2.1, the field can be removed and the setter deprecated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message