Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 76F2A4D55 for ; Wed, 13 Jul 2011 12:14:29 +0000 (UTC) Received: (qmail 29705 invoked by uid 500); 13 Jul 2011 12:14:28 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 29337 invoked by uid 500); 13 Jul 2011 12:14:27 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 29310 invoked by uid 99); 13 Jul 2011 12:14:27 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jul 2011 12:14:27 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jul 2011 12:14:21 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 645844E74C for ; Wed, 13 Jul 2011 12:14:00 +0000 (UTC) Date: Wed, 13 Jul 2011 12:14:00 +0000 (UTC) From: "Gilles (JIRA)" To: issues@commons.apache.org Message-ID: <1933813757.9575.1310559240406.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <880300261.14789.1305531707356.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (MATH-577) Enhance Complex.java MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MATH-577?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D130645= 08#comment-13064508 ]=20 Gilles commented on MATH-577: ----------------------------- For new functionality like "add", "subtract", "multiply", "divide", a patch= (with unit tests!) uploaded here will be fine. Since "hashCode" and "equals" have already generated contradicting opinions= , it's probably better to start a discussion on the "dev" ML. > Enhance Complex.java > -------------------- > > Key: MATH-577 > URL: https://issues.apache.org/jira/browse/MATH-577 > Project: Commons Math > Issue Type: Improvement > Affects Versions: 3.0 > Reporter: Arne Pl=C3=B6se > Priority: Minor > Attachments: Complex.diff, Complex.diff > > > Add some double shorthand methods to Complex fix different NaN checks in = add and subtract ! Testcase testAddNaN will fail (what should be the resul= t ?) > What is missing JavaDoc and testcases. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira