Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Mon, 18 Jul 2011 18:13:57 +0000 (UTC)
From: "Gilles (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <1694055733.992.1311012837506.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <880300261.14789.1305531707356.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MATH-577) Enhance Complex.java
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MATH-577?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D130671=
89#comment-13067189 ]=20

Gilles commented on MATH-577:
-----------------------------

Maybe a combination of my version and yours...
I don't like "shorthand" since it might let users wonder whether a temporar=
y Complex variable is created.
The "@see" tag is fine.
I also wonder why the parameter is called "rhs".

So:
{code}
/**
 * Computes the sum of this complex number and the given scalar number.
 *=20
 * @param c Number to add.
 * @return {@code this + c}.
 * @see #add(Complex)
 */
public Complex add(double rhs) {
    if (isNaN || Double.isNaN(rhs)) {
      return NaN;
    }
    return createComplex(real + rhs, imaginary);
}
{code}


> Enhance Complex.java
> --------------------
>
>                 Key: MATH-577
>                 URL: https://issues.apache.org/jira/browse/MATH-577
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Arne Pl=C3=B6se
>            Priority: Minor
>         Attachments: Complex.diff, Complex.diff, Complex.diff
>
>
> Add some double shorthand methods to Complex fix different NaN checks in =
add and subtract ! Testcase  testAddNaN will fail (what should be the resul=
t ?)
> What is missing JavaDoc and testcases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira