Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 7 Jul 2011 19:32:16 +0000 (UTC)
From: "Mark Thomas (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <1315201056.8753.1310067136863.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: <19525772.141861288360460328.JavaMail.jira@thor>
Subject: [jira] [Resolved] (POOL-177) GenericKeyedObjectPoolFactory and
 GenericObjectPoolFactory to share a common superclass
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/POOL-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Thomas resolved POOL-177.
------------------------------

    Resolution: Won't Fix

Having restarted the pool2 re-factoring using dbcp2 as a reality check for what we do with pool2, GenericObjectPoolFactory and GenericKeyedObjectPoolFactory have nothing in common that could usefully be pulled up into a base class.

> GenericKeyedObjectPoolFactory and GenericObjectPoolFactory to share a common superclass
> ---------------------------------------------------------------------------------------
>
>                 Key: POOL-177
>                 URL: https://issues.apache.org/jira/browse/POOL-177
>             Project: Commons Pool
>          Issue Type: Improvement
>    Affects Versions: Nightly Builds
>            Reporter: Gary D. Gregory
>             Fix For: 2.0
>
>         Attachments: POOL-177.diff, POOL-177.diff
>
>
> I see now in trunk that GenericKeyedObjectPoolConfig extends GenericObjectPoolConfig, which I like.
> It seems that the next step would be for GenericKeyedObjectPoolFactory and GenericObjectPoolFactory to share a common superclass.
> To see what I mean, look at the patch in this ticket.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira