Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3BE9D60E6 for ; Wed, 13 Jul 2011 19:47:25 +0000 (UTC) Received: (qmail 55504 invoked by uid 500); 13 Jul 2011 19:47:23 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 55172 invoked by uid 500); 13 Jul 2011 19:47:22 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 55156 invoked by uid 99); 13 Jul 2011 19:47:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jul 2011 19:47:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jul 2011 19:47:21 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A7D674ED62 for ; Wed, 13 Jul 2011 19:47:00 +0000 (UTC) Date: Wed, 13 Jul 2011 19:47:00 +0000 (UTC) From: =?utf-8?Q?Arne_Pl=C3=B6se_=28JIRA=29?= To: issues@commons.apache.org Message-ID: <1209255326.11044.1310586420684.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <880300261.14789.1305531707356.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (MATH-577) Enhance Complex.java MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MATH-577?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D130648= 07#comment-13064807 ]=20 Arne Pl=C3=B6se commented on MATH-577: --------------------------------- Maybe Im a little dumb, but why are Complex.add and Complex.subtract differently implemented regarding NaN values? subtract returns Complex.NaN if there is one of both NaN. Am Mittwoch, den 13.07.2011, 14:47 +0000 schrieb Phil Steitz (JIRA):=20 I only found your checkin of revision 280031 where you intoduced NaN in equals, but cant find anything on commons-dev (maybe I got the wrong keywords hashCode, equals)? > Enhance Complex.java > -------------------- > > Key: MATH-577 > URL: https://issues.apache.org/jira/browse/MATH-577 > Project: Commons Math > Issue Type: Improvement > Affects Versions: 3.0 > Reporter: Arne Pl=C3=B6se > Priority: Minor > Attachments: Complex.diff, Complex.diff > > > Add some double shorthand methods to Complex fix different NaN checks in = add and subtract ! Testcase testAddNaN will fail (what should be the resul= t ?) > What is missing JavaDoc and testcases. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira