commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William R. Speirs (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DBUTILS-79) fillStatement doesn't complain when there are too few parameters
Date Fri, 29 Jul 2011 13:58:09 GMT
fillStatement doesn't complain when there are too few parameters
----------------------------------------------------------------

                 Key: DBUTILS-79
                 URL: https://issues.apache.org/jira/browse/DBUTILS-79
             Project: Commons DbUtils
          Issue Type: Bug
    Affects Versions: 1.3
            Reporter: William R. Speirs
             Fix For: 1.4


Unless I'm reading the code incorrectly, it appears that the fillStatement function does not
complain if you provide too few parameters. For example, if you supply an SQL statement like:
select * from blah where ? = ?; but only provide a single parameter "test", fillStatement
returns without issue. However, only the first ? is actually set.

Granted, this will almost always cause an exception to be thrown by the driver, but since
there is already a check for too many parameters, why not check for too few as well?

(FYI: I came across this bug, and a few others in my AsyncQueryRunner implementation, while
re-writing the unit tests to use Mockito.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message