commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Steitz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-609) [patch] push down code to inner blocks where they are needed
Date Sat, 02 Jul 2011 22:04:21 GMT

    [ https://issues.apache.org/jira/browse/MATH-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059131#comment-13059131
] 

Phil Steitz commented on MATH-609:
----------------------------------

Other than extra parens in the last clause of the return in the LaguerreSolver patch, these
all look good to me.  Anyone have any objections?

Thanks for the patch!

> [patch] push down code to inner blocks where they are needed
> ------------------------------------------------------------
>
>                 Key: MATH-609
>                 URL: https://issues.apache.org/jira/browse/MATH-609
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 3.0
>
>         Attachments: bas.diff
>
>
> code does calculations at a scope level that is not needed, push these calculations down
to where those calculations are needed, to avoid executing code that is unnecessary.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message