commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Max Tardiveau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JEXL-113) Dot notation behaves unexpectedly with null values
Date Sun, 10 Jul 2011 08:16:01 GMT

    [ https://issues.apache.org/jira/browse/JEXL-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062697#comment-13062697
] 

Max Tardiveau commented on JEXL-113:
------------------------------------

That would be ideal! But I'm not sure I understand the return value. If my expression is:

a + b.c + d.e.f

I assume I'd get:

{ {"a"}, {"b", "c"}, {"d", "e", "f"} }

I think a return type of Set<String> would be sufficient, since parsing dots should
probably be left to the caller (since only they know what the dots mean). So I'd just get:

{ "a", "b.c", "d.e.f" }

which would be adequate. Either way would work, of course, I'm just trying to figure out what
makes the most sense.

Thanks!

-- Max




> Dot notation behaves unexpectedly with null values
> --------------------------------------------------
>
>                 Key: JEXL-113
>                 URL: https://issues.apache.org/jira/browse/JEXL-113
>             Project: Commons JEXL
>          Issue Type: Bug
>    Affects Versions: 2.0.1
>         Environment: JDK 1.6
>            Reporter: Max Tardiveau
>
> When a variable of the form a.b is evaluated, the context is asked first for the value
of a. That value is then asked for the value of b.
> So far, so good: this is exactly what you'd expect from the dot operator.
> But if the value of b is null, the context is then asked for the value of a.b, in other
words the dot operator is ignored and "a.b" is considered to be a single variable.
> This is at best confusing. Granted, this can be avoided with the a['b'] notation, but
that's clumsy.
> I assume this is an attempt to support both the dot operator and ant-style variables.
I don't think you can have both and remain sane.
> Suggestion: either document this behavior, or make it an option. My vote would be to
just use the value returned, even if it's null. Either dot is an operator, or it's not. Perhaps
make that configurable?
> Thanks!

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message