commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-577) Enhance Complex.java
Date Tue, 19 Jul 2011 12:09:58 GMT

    [ https://issues.apache.org/jira/browse/MATH-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067652#comment-13067652
] 

Gilles commented on MATH-577:
-----------------------------

I didn't know the word "augend".
It seems rather old-fashioned:
* http://en.wikipedia.org/wiki/Addition

And, if I refer to these links:
* http://www.thefreedictionary.com/augend
* http://mathworld.wolfram.com/Augend.html

its use in the Javadoc of {{BigDecimal}} is not correct, as the augend would be {{this}} and
not the parameter of the {{add}} method.

Concerning the style, it seems OK, except that you should replace
{noformat}
<code>...</code>
{noformat}
with
{noformat}
{@code ...}
{noformat}

[Also, you've forgotten a "rhs" in the "@throws" Javadoc...]


> Enhance Complex.java
> --------------------
>
>                 Key: MATH-577
>                 URL: https://issues.apache.org/jira/browse/MATH-577
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Arne Plöse
>            Priority: Minor
>         Attachments: Complex.diff, Complex.diff, Complex.diff
>
>
> Add some double shorthand methods to Complex fix different NaN checks in add and subtract
! Testcase  testAddNaN will fail (what should be the result ?)
> What is missing JavaDoc and testcases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message