Return-Path: 
 <issues-return-19263-apmail-commons-issues-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-issues-archive@minotaur.apache.org
Delivered-To: apmail-commons-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D1E3465B5
	for <apmail-commons-issues-archive@minotaur.apache.org>;
 Sat, 11 Jun 2011 18:33:21 +0000 (UTC)
Received: (qmail 63849 invoked by uid 500); 11 Jun 2011 18:33:21 -0000
Delivered-To: apmail-commons-issues-archive@commons.apache.org
Received: (qmail 63799 invoked by uid 500); 11 Jun 2011 18:33:21 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 63791 invoked by uid 99); 11 Jun 2011 18:33:21 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jun 2011 18:33:21 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jun 2011 18:33:19 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 0F38D1101F0
	for <issues@commons.apache.org>; Sat, 11 Jun 2011 18:32:59 +0000 (UTC)
Date: Sat, 11 Jun 2011 18:32:59 +0000 (UTC)
From: "Luc Maisonobe (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <81665817.14169.1307817179057.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: <8741839.48931295402444839.JavaMail.jira@thor>
Subject: [jira] [Commented] (MATH-485) Feature Request: Kalman Filter
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/MATH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047964#comment-13047964 ] 

Luc Maisonobe commented on MATH-485:
------------------------------------

>From a quick look, this seems good to me.
There are still some missing javadoc (on private fields) and missing </i> in the html. It would also be nice to have in the javadoc for KalmanFilter class an explanation of the meaning of the matrices and vectors (A = transition matrix, B control matrix, u control vector ...).

There is one point that bothers me. The ProcessModel and MeasurementModel interfaces define methods to retrieve the process noise and measurement noise that don't have any parameter. Thus the user can only implement constant noises, not time-dependant noises when he implement the interfaces (or use the default implementation, which are constant). Wouldn't it be more general to add an integer parameter for the step number ? The default implementation would ignore it and always return the same matrices, but users may want to have custom implementation using the informatio of the current step.

Concerning the formatting you should check the style with checkstyle. Typically, tabulation is completely forbidden and for line breaks, the operators should remain at the end of the previous line, not at the beginning of the next line.

> Feature Request: Kalman Filter
> ------------------------------
>
>                 Key: MATH-485
>                 URL: https://issues.apache.org/jira/browse/MATH-485
>             Project: Commons Math
>          Issue Type: Wish
>            Reporter: Benjamin McCann
>             Fix For: 3.0
>
>         Attachments: KalmanFilterExample.java, MATH-485-update1.patch, MATH-485.patch
>
>
> I'd love it if Commons Math could add support for the Kalman filter.  Here are a few implementations that might be able to be used for reference or included if they're using compatible licenses:
> http://code.google.com/p/efficient-java-matrix-library/wiki/KalmanFilterExamples
> http://mathstat.asu.edu/~eubank/
> http://www.fit.vutbr.cz/research/prod/index.php.en?id=53&notitle=1
> http://sourceforge.net/projects/jkalman/
> http://www.vni.com/products/imsl/jmsl/v30/api/com/imsl/stat/KalmanFilterEx1.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira