Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D535C4701 for ; Sat, 4 Jun 2011 19:01:29 +0000 (UTC) Received: (qmail 41587 invoked by uid 500); 4 Jun 2011 19:01:29 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 41523 invoked by uid 500); 4 Jun 2011 19:01:28 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 41295 invoked by uid 99); 4 Jun 2011 19:01:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Jun 2011 19:01:28 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Jun 2011 19:01:27 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 9C0F0100617 for ; Sat, 4 Jun 2011 19:00:47 +0000 (UTC) Date: Sat, 4 Jun 2011 19:00:47 +0000 (UTC) From: "Sebb (JIRA)" To: issues@commons.apache.org Message-ID: <1936483253.68776.1307214047635.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <159100663.5585.1300234169701.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (NET-374) ParserInitializationException doesn't use standard JDK exception chaining MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/NET-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated NET-374: --------------------- Fix Version/s: 3.0 > ParserInitializationException doesn't use standard JDK exception chaining > ------------------------------------------------------------------------- > > Key: NET-374 > URL: https://issues.apache.org/jira/browse/NET-374 > Project: Commons Net > Issue Type: Improvement > Components: FTP > Affects Versions: 2.2 > Reporter: Daniel Gredler > Priority: Minor > Fix For: 3.0 > > > ParserInitializationException appears to have its own rootCause instance variable, rather than using RuntimeException's constructors which allow a cause to be specified (ParserInitializationException extends RuntimeException). So for example on line 53 of this class [1], I would expect to see a simple invocation to super(message, rootCause). > The reason this has come up is that we're logging these exceptions using log4j, but because ParserInitializationException doesn't use the standard JDK exception chaining, we don't get visibility into the root issue in the logs. > This was discussed briefly on the user mailing list [2]. > [1] http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/ParserInitializationException.java?view=markup > [2] http://markmail.org/thread/6hn3doow352ic6ho -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira