commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary D. Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CODEC-125) beider morse phonetic matching codec
Date Tue, 28 Jun 2011 17:17:17 GMT

    [ https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056646#comment-13056646
] 

Gary D. Gregory commented on CODEC-125:
---------------------------------------

Here are some code comments: 

h3. Class name
BeiderMorsePhoneticMatching should probably be called BeiderMorsePhoneticMatcher, BeiderMorsePhoneticEncoder,
or BeiderMorseEncoder.

The class is an Encoder. Not all [codec] encoders are postfixed with Encoder, so there is
a precedent for having just BeiderMorse but I think BeiderMorseEncoder is clearer.

h3. Resource files
For your resource files, I think you should follow the existing naming standards (en for English
for example.)

See java.util.Locale, java.util.ResourceBundle, and java.util.Properties.

The least surprises and reinvention of the wheel the better IMO.

It seems like it would be better to at least use the java.util.Properties file format.

h3. Package name
What does the PS stand for in BMPS? P for Phonetic? S for?

> beider morse phonetic matching codec
> ------------------------------------
>
>                 Key: CODEC-125
>                 URL: https://issues.apache.org/jira/browse/CODEC-125
>             Project: Commons Codec
>          Issue Type: New Feature
>            Reporter: Matthew Pocock
>            Priority: Minor
>         Attachments: bmpm.patch
>
>
> I have implemented Beider Morse Phonetic Matching as a codec against the commons-codec
svn trunk. I would like to contribute this to commons-codec.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message