Return-Path: 
 <issues-return-18780-apmail-commons-issues-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-issues-archive@minotaur.apache.org
Delivered-To: apmail-commons-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7DEAF6230
	for <apmail-commons-issues-archive@minotaur.apache.org>;
 Sat, 14 May 2011 15:06:28 +0000 (UTC)
Received: (qmail 54385 invoked by uid 500); 14 May 2011 15:06:28 -0000
Delivered-To: apmail-commons-issues-archive@commons.apache.org
Received: (qmail 54309 invoked by uid 500); 14 May 2011 15:06:27 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 54301 invoked by uid 99); 14 May 2011 15:06:27 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 May 2011 15:06:27 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 May 2011 15:06:26 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 57ED2CAEC8
	for <issues@commons.apache.org>; Sat, 14 May 2011 15:05:47 +0000 (UTC)
Date: Sat, 14 May 2011 15:05:47 +0000 (UTC)
From: =?utf-8?Q?Arne_Pl=C3=B6se_=28JIRA=29?= <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <579724711.13073.1305385547356.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <141081477.34201.1305015903182.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MATH-573) in ArrayFielVector i.e. subtract
 calls wrong constructor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/MATH-573?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D130335=
44#comment-13033544 ]=20

Arne Pl=C3=B6se commented on MATH-573:
---------------------------------

OK so fare.

I hope that you don't flame me for nagging you again :-)

Looking at RealArrayVecor and FieldArrayVector I see different implementati=
ons of mapSOMETHING ... Maybe check performance, define some best condiing =
practice and refactor | clean up?

Furthermore I saw the checkDimension() is sometimes called sometimes not? -=
 Just a hint...=20

> in ArrayFielVector i.e. subtract calls wrong constructor
> --------------------------------------------------------
>
>                 Key: MATH-573
>                 URL: https://issues.apache.org/jira/browse/MATH-573
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.0
>            Reporter: Arne Pl=C3=B6se
>            Priority: Minor
>             Fix For: 3.0
>
>
> I.E. subtract calls
> "return new ArrayFieldVector<T>(out)" this constructor clones the array..=
.
> "return new ArrayFieldVector<T>(field, out, false)" would be better (pres=
erving field as well)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira