Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 12 May 2011 07:56:47 +0000 (UTC)
From: "Simone Tripodi (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <515125459.6189.1305187007401.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1022056339.6114.1305184667438.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (OGNL-8) use javacc to generate AST* java
 sources
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/OGNL-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032295#comment-13032295 ] 

Simone Tripodi commented on OGNL-8:
-----------------------------------

Just one big reminder for who will take care of the issue: during OGNL evolution, generated JavaCC sources have been versioned in the SCM and *modified*.
That is wrong, because let's suppose grammar has bugs, once fixed and when re-generating the sources, they will be overridden, loosing latest modifications :(

The necessary steps are:

 * Plug the JavaCC Plugin for Maven [http://mojo.codehaus.org/javacc-maven-plugin/];
 * See which classes are generated (AST*.java classes and few more);
 * Understand which methods have been added in the versioned;
 * Merging all those methods inside the JavaCC grammar

I already tried this before OGNL joined the Incubator, but not being JavaCC expert I fixed that issue only partially, I missed the last point.

Feel free to ping me directly if any help is needed!

> use javacc to generate AST* java sources
> ----------------------------------------
>
>                 Key: OGNL-8
>                 URL: https://issues.apache.org/jira/browse/OGNL-8
>             Project: OGNL (Incubating)
>          Issue Type: Task
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira