Return-Path: 
 <issues-return-18609-apmail-commons-issues-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-issues-archive@minotaur.apache.org
Delivered-To: apmail-commons-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 676F24FA4
	for <apmail-commons-issues-archive@minotaur.apache.org>;
 Mon,  9 May 2011 18:02:45 +0000 (UTC)
Received: (qmail 21135 invoked by uid 500); 9 May 2011 18:02:44 -0000
Delivered-To: apmail-commons-issues-archive@commons.apache.org
Received: (qmail 21073 invoked by uid 500); 9 May 2011 18:02:44 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 21065 invoked by uid 99); 9 May 2011 18:02:44 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 May 2011 18:02:44 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 May 2011 18:02:42 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 2908DC8A65
	for <issues@commons.apache.org>; Mon,  9 May 2011 18:02:03 +0000 (UTC)
Date: Mon, 9 May 2011 18:02:03 +0000 (UTC)
From: "Luc Maisonobe (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <451318266.32940.1304964123164.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1917783806.32201.1304943483496.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MATH-570) Change some constructors of
 ArrayFieldVector to accept FieldVector
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/MATH-570?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D130308=
35#comment-13030835 ]=20

Luc Maisonobe commented on MATH-570:
------------------------------------

The purpose of the large number of constructors is precisely to avoid spuri=
ous copies.
So I would consider their existence as a feature.

> Change some constructors of ArrayFieldVector to accept FieldVector
> ------------------------------------------------------------------
>
>                 Key: MATH-570
>                 URL: https://issues.apache.org/jira/browse/MATH-570
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Arne Pl=C3=B6se
>            Priority: Minor
>
> the constructor     public ArrayFieldVector(T[] v1, ArrayFieldVector<T> v=
2) {
>  ...=20
> }
> takes an ArrayFieldVector.
> but the same can be easier archieved with this=20
>     public ArrayFieldVector(T[] v1, FieldVector<T> v2) {
>         this(v1, v2 =3D=3D null ? null : v2.getData());
>     }
> this goes for all other constructors...
> P.S. I donk know if copying the data in getData is an issue ... for this =
the named constructor may make sense...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira