commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Arne Plöse (JIRA) <j...@apache.org>
Subject [jira] [Commented] (MATH-573) in ArrayFielVector i.e. subtract calls wrong constructor
Date Wed, 11 May 2011 17:19:47 GMT

    [ https://issues.apache.org/jira/browse/MATH-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031864#comment-13031864
] 

Arne Plöse commented on MATH-573:
---------------------------------

At least copy() and public constructor Array2DRowFieldMatrix<T> add(final Array2DRowFieldMatrix<T>
m) in Array2DRowFieldMatrix.java ignores field | there is no contract what should happen with
field (whetzer it is to pe basses or not, and if yes after what pattern) - so not really a
bug more a hint.

Maybe an other issue: should the ArrayFieldVector v from which data is used, not given the
chance to review its internal state by asking v.getDataRef() instead of simply taking v.data
(currently just a philosophical question :-)) ?

> in ArrayFielVector i.e. subtract calls wrong constructor
> --------------------------------------------------------
>
>                 Key: MATH-573
>                 URL: https://issues.apache.org/jira/browse/MATH-573
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.0
>            Reporter: Arne Plöse
>            Priority: Minor
>             Fix For: 3.0
>
>
> I.E. subtract calls
> "return new ArrayFieldVector<T>(out)" this constructor clones the array...
> "return new ArrayFieldVector<T>(field, out, false)" would be better (preserving
field as well)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message