commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Arne Plöse (JIRA) <j...@apache.org>
Subject [jira] [Commented] (MATH-573) in ArrayFielVector i.e. subtract calls wrong constructor
Date Sat, 14 May 2011 15:05:47 GMT

    [ https://issues.apache.org/jira/browse/MATH-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033544#comment-13033544
] 

Arne Plöse commented on MATH-573:
---------------------------------

OK so fare.

I hope that you don't flame me for nagging you again :-)

Looking at RealArrayVecor and FieldArrayVector I see different implementations of mapSOMETHING
... Maybe check performance, define some best condiing practice and refactor | clean up?

Furthermore I saw the checkDimension() is sometimes called sometimes not? - Just a hint...


> in ArrayFielVector i.e. subtract calls wrong constructor
> --------------------------------------------------------
>
>                 Key: MATH-573
>                 URL: https://issues.apache.org/jira/browse/MATH-573
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.0
>            Reporter: Arne Plöse
>            Priority: Minor
>             Fix For: 3.0
>
>
> I.E. subtract calls
> "return new ArrayFieldVector<T>(out)" this constructor clones the array...
> "return new ArrayFieldVector<T>(field, out, false)" would be better (preserving
field as well)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message