commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Created] (POOL-188) Confusing PoolUtils.ErodingKeyedObjectPool.numIdle(K key) method; bug in ErodingKeyedObjectPool.returnObject(K key, V obj) ?
Date Wed, 11 May 2011 12:16:47 GMT
Confusing PoolUtils.ErodingKeyedObjectPool.numIdle(K key) method; bug in ErodingKeyedObjectPool.returnObject(K
key, V obj) ?
----------------------------------------------------------------------------------------------------------------------------

                 Key: POOL-188
                 URL: https://issues.apache.org/jira/browse/POOL-188
             Project: Commons Pool
          Issue Type: Bug
    Affects Versions: 2.0
            Reporter: Sebb


numIdle(key) is equivalent to PoolUtils.ErodingKeyedObjectPool.getNumIdle() - unless the method
getKeyedPool() is overridden.

It's confusing that the key parameter is not used - this may be the cause of a bug, as the
method is used internally by ErodingKeyedObjectPool.returnObject(K key, V obj).

It looks like returnObject() should probably call getNumIdle(key) rather than numIdle(key).
In which case the confusing numIdle method can be deleted.



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message